-
Notifications
You must be signed in to change notification settings - Fork 1.2k
🐛Use k8s.io/apimachinery/pkg/util/json to unmarshal in fakeclient #3208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Use k8s.io/apimachinery/pkg/util/json to unmarshal in fakeclient #3208
Conversation
43929d1
to
dde4486
Compare
73e4dac
to
a4ac626
Compare
/hold |
@troy0820 All good from my side. Do you have time to add a unit test? It would be nice to get this into CR v0.21 |
Yes, I am going to work on this today. |
Thank you very much! |
a4ac626
to
4e708fe
Compare
Strange: #3208 (comment) |
4e708fe
to
643737a
Compare
@troy0820 One thing I forgot. Please squash the commits and update the one message according to the changes |
fbc3f25
to
bbb1e12
Compare
bbb1e12
to
d9721fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nits from my side. Thx everyone for working on this!
Signed-off-by: Troy Connor <[email protected]>
d9721fa
to
b3278df
Compare
Thx everyone! /lgtm /assign @alvaroaleman |
LGTM label has been added. Git tree hash: a2d28d8c5336a2b472ada822fb0ce8df2224d73c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, troy0820 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will use
k8s.io/apimachinery/pkg/util/json
which callssigs.k8s.io/json
toUnmarshalWithCaseSensitivePreserveInts
in the fakeclient.Resolves #3207
NOTE: https://pkg.go.dev/sigs.k8s.io/json#UnmarshalCaseSensitivePreserveInts